Skip to content

Commit

Permalink
Remove C++ linking from oso_prefix feature for now
Browse files Browse the repository at this point in the history
Currently in the macOS toolchain C++ linking goes through
`cc_wrapper.sh`, not `wrapped_clang`. I didn't add the handling to
`cc_wrapper` for this argument. These wrappers will likely go away soon,
when they do we should probably make them route to wrapped_clang
instead, in which case we could revert this.

#12304

Closes #12356.

PiperOrigin-RevId: 340817292
  • Loading branch information
keith authored and copybara-github committed Nov 5, 2020
1 parent 74ca288 commit 306e5f1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tools/osx/crosstool/cc_toolchain_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -5722,8 +5722,7 @@ def _impl(ctx):
name = "oso_prefix_is_pwd",
flag_sets = [
flag_set(
actions = all_link_actions +
["objc-executable", "objc++-executable"],
actions = ["objc-executable", "objc++-executable"],
flag_groups = [flag_group(flags = ["OSO_PREFIX_MAP_PWD"])],
),
],
Expand Down

0 comments on commit 306e5f1

Please sign in to comment.