Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mingw_gcc_compiler config_setting to add_build_file.patch #1579

Closed
wants to merge 1 commit into from
Closed

add mingw_gcc_compiler config_setting to add_build_file.patch #1579

wants to merge 1 commit into from

Conversation

vvviktor
Copy link
Contributor

@vvviktor vvviktor commented Mar 4, 2024

Building zlib under Windows MINGW GCC toolchain fails with [-fpermissive] errors.

Here is failure reproduction example. The command is bazel build @zlib//:zlib

Toolchain along with setup instructions is here.

My workaround is to add config_setting rule for mingw-gcc compiler. So it will add -fpermissive flag if CCToolchainInfo.compiler is set to mingw-gcc.

@bazel-io
Copy link
Member

bazel-io commented Mar 4, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (zlib) have been updated in this PR. Please review the changes.

@meteorcloudy
Copy link
Member

meteorcloudy commented Mar 5, 2024

@vvviktor Existing module should never be changed. Can you please send this update as a new version (1.3.1.bcr.1)? Check https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#versions-format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants