Updates for rules_apple resource rules #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-malik
commented
Mar 1, 2019
rahul-malik
commented
Mar 1, 2019
rahul-malik
commented
Mar 1, 2019
rahul-malik
force-pushed
the
rmalik-new-resource-rules
branch
from
8a39d73 to
5b76c91
Compare
|
@jerrymarino @mikezucc Mind taking a look at this PR so I know if it’s good to merge? |
|
On first look this seems good. I’d suggest removing the operator instead of the deprecation warning ( also suggest enjoying the moment doing fun things 😊 ) |
- objc_bundle is now apple_bundle_import - Bundles and resources are passed through the `data` value of objc_library - Added function to optionally add load statements based on the types of skylark nodes in the build files (swift, apple resource bundles, etc)
rahul-malik
force-pushed
the
rmalik-new-resource-rules
branch
from
b521008 to
fd49d7d
Compare
|
@jerrymarino @mikezucc Updated, mind approving? |
|
@jerrymarino @mikezucc ping? I want to merge so #72 can be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
datavalue ofobjc_library
skylark nodes in the build files (swift, apple resource bundles, etc)
Remaining work