[Bazel6] Remove --experimental_worker_allow_json_protocol
#615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port bazelbuild/bazel#14679 into `rules_ios` to prepare for Bazel 6.0.0.
|
Let me know if you all know there's a reason to leave this around. Seems like it was added as a default ability much before removal. |
luispadron
approved these changes
Nov 28, 2022
jerrymarino
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
@mattrobmattrob LGTM - I was curious if this actually had a functional impact prior to 6.0 / surprised it didn't break 5.3.2
|
Edit: according to the linked thread - the related fix was likely cherry-picked onto 5.x.x at some point |
mattrobmattrob
deleted the
mr/remove.experimental_worker_allow_json_protocol
branch
mattrobmattrob
changed the title
--experimental_worker_allow_json_protocol--experimental_worker_allow_json_protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle bazelbuild/bazel#14679 to prepare for Bazel 6.0.0.