Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI pipeline #55

Merged
merged 1 commit into from
Jan 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
runs-on: macos-latest
steps:
- uses: actions/checkout@v1
- name: Select Xcode 12.2
run: sudo xcode-select -s /Applications/Xcode_12.2.app
- name: Print Xcode version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fixing something specific you're facing?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rarely but sometimes older versions get deprecated. E.g

actions/runner-images#4060

Min version is 12.4 after this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe this plugin has little dep on xcode and its implementations so it's fine to just rely on latest version for now until we face problems

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, see an example: https://github.com/bazel-ios/cocoapods-bazel/runs/4740577782?check_suite_focus=true

That said I'm ok with changing this for now and see how CI behaves

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for sharing the example too @chenxiao0228!

run: sudo xcode-select -p
- uses: actions/setup-ruby@v1
with:
ruby-version: "2.x" # Version range or exact version of a Ruby version to use, using semvers version range syntax.
Expand Down
2 changes: 1 addition & 1 deletion spec/integration/experimental_features/spec.yml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
description: generates build files in a CocoaPods monorepo
description: generates build files in a CocoaPods monorepo with experiment feature on