fix: fix starlark debugger broken in release 0.11.0 (#432) #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uch as pbjs, pbts, js-yaml and tsc
dpar39
requested review from
coeuvre,
jfirebaugh,
cameron-martin and
vogelsgesang
as code owners
dpar39
changed the title
dpar39
changed the title
dpar39
commented
Jan 29, 2025
|
|
||
| const value = ( | ||
| await this.bazelConnection.sendRequest({ | ||
| try { |
There was a problem hiding this comment.
This try ... catch is needed to avoid that when hovering over starlark code, vscode automatically requests 'evaluation' of the statement under mouse cursor. Without it, starlark EvaluateResponses such as:
sequence_number: 33
error {
message: "name \'target\' is not defined"
}
causes the debugger program to crash.
On another note, I can't find how to evaluate variables like target or ctx on the debugger. I see the evaluate request takes the thread_id and the statement, but I can only successfully evaluate in the global scope of the current thread, i.e., cannot evaluate call stack local variables. Is this a limitation of the Starlark debugger or something we are missing in the adapter?
cameron-martin
changed the title
cameron-martin
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes starlark debugging which is broken in release 0.11.0 #432. The debugger program currently fails to start because it can't import vscode. In addition, it also fixes hovering over symbols with starlark debugger respond with errors because symbols are not defined.