Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle external dependencies #416

Open
1 of 6 tasks
cwahbong opened this issue Oct 14, 2024 · 0 comments
Open
1 of 6 tasks

Handle external dependencies #416

cwahbong opened this issue Oct 14, 2024 · 0 comments

Comments

@cwahbong
Copy link
Contributor

cwahbong commented Oct 14, 2024 •
edited
Loading

Seems the current plugin implementation does not handle the external dependencies well: when specify "Query Expression" in configuration like: @repo//..., the tree explorer, coverage, and the quick pick is not showing the dependencies from external dependencies. This makes some workspaces that's organized in assembling local_repository rules not working.

I already have several local workaround fixes for this, but it would be better to also append the test cases for better coverage and prevent regressions for existing users..

  • Coverage: handle the generated report path's SF:external/<repo>/.... entries.
  • Ｑuick picks: replace hard coded queries like //...:* or //...) to query expressions. Not sure if we have to use separate query for packages and targets.
  • Code lens: still exploring / surveying. Seems we have to map the BUILD files back to @repo//path:BUILD, which is a opposite direction to those mapping in tree explorer and coverage.
  • Tree explorer:
    • Replace hard coded queries to query expression.
    • Make the grouping handles the package name starting with @<repo>//.
cwahbong added a commit to cwahbong/vscode-bazel that referenced this issue Oct 14, 2024
@cwahbong
fix(coverage): Do not emit error on 0-th line DA entries.
ce3fb4a 
Works towards bazel-contrib#416.
cwahbong added a commit to cwahbong/vscode-bazel that referenced this issue Oct 14, 2024
@cwahbong
fix(coverage): Expand external dependencies in coverage report.
d692f50 
Works towards bazel-contrib#416.
cwahbong added a commit to cwahbong/vscode-bazel that referenced this issue Oct 15, 2024
@cwahbong
fix(coverage): Expand external local repo in coverage report
8aa2a16 
Rules under repo local_repository() are external repo but symlinked
to a local path, usually in the same workspace.

No matter if the local path is in the same workspace, the users should
usually want to check the local path specified in local_repository rules
instead of the path in bazel output
(<bazel workspace>/bazel-<repo>/external/...) in
file explorer.

Works towards bazel-contrib#416.
cwahbong added a commit to cwahbong/vscode-bazel that referenced this issue Oct 15, 2024
@cwahbong
fix(coverage): Expand external local repo in coverage report
2155cce 
Rules under repo local_repository() are external repo but symlinked
to a local path, usually in the same workspace.

No matter if the local path is in the same workspace, the users should
usually want to check the local path specified in local_repository rules
instead of the path in bazel output
(<bazel workspace>/bazel-<repo>/external/...) in
file explorer.

Works towards bazel-contrib#416.
cwahbong added a commit to cwahbong/vscode-bazel that referenced this issue Oct 15, 2024
@cwahbong
fix(coverage): Expand external local repo in coverage report
4b03f0d 
Rules under repo local_repository() are external repo but symlinked
to a local path, usually in the same workspace.

No matter if the local path is in the same workspace, the users should
usually want to check the local path specified in local_repository rules
instead of the path in bazel output
(<bazel workspace>/bazel-<repo>/external/...) in
file explorer.

Works towards bazel-contrib#416. Imporved bazel-contrib#362.
cwahbong added a commit to cwahbong/vscode-bazel that referenced this issue Oct 15, 2024
@cwahbong
fix(coverage): Expand external local repo in coverage report
4da3441 
Rules under repo local_repository() are external repo but symlinked
to a local path, usually in the same workspace.

No matter if the local path is in the same workspace, the users should
usually want to check the local path specified in local_repository rules
instead of the path in bazel output
(<bazel workspace>/bazel-<repo>/external/...) in
file explorer.

Works towards bazel-contrib#416. Imporves bazel-contrib#362.
@cwahbong cwahbong mentioned this issue Oct 15, 2024
Merged
vogelsgesang pushed a commit that referenced this issue Oct 16, 2024
@cwahbong
fix(coverage): Expand external local repo in coverage report (#418)
c115a86 
Rules under repo local_repository() are external repo but symlinked
to a local path, usually in the same workspace.

No matter if the local path is in the same workspace, the users should
usually want to check the local path specified in local_repository rules
instead of the path in bazel output (`<bazel workspace>/bazel-<repo>/external/...`)
in the file explorer.

Works towards #416. Improves #362.
@cwahbong cwahbong mentioned this issue Oct 22, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cwahbong