fix(typescript): support @npm_bazel_typescript workspace with install_bazel_dependencies for @bazel/typescript package #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_bazel_dependencies for @bazel/typescript package This allows for rules_nodejs 2.0 compatability with the current @angular/bazel package, which imports from @npm_bazel_typescript, without having to patch the nnpm package. LinkablePackageInfo was added in @angular/bazel 10.1.0-next.0 release. Together with this fix this allows us to remove the patches from examples/angular_view_engine. Future release of @angular/bazel will be updated to the new package format and support @npm//@angular/bazel:index.bzl loads. This is in progress in angular/angular#37727. This support will likely be removed in rules_nodejs 3.0.
|
Nevermind. This is impossible as for @bazel/typescript 2.0.0 the internal import paths such as We will need a minimal patch to @angular/bazel to support rules_nodejs 2.0 until angular/angular#37727 lands and make it into a release. |
gregmagolan
pushed a commit
to gregmagolan/rules_nodejs
that referenced
this pull request
Jul 15, 2020
…ext.0 LinkablePackageInfo now part of ng_module with that release so patch can be simplified to just patching the @npm_bazel_typescript imports. That minimal path is required for @angular/bazel until the package is upgraded to new rules_nodejs 2.0 package format. See bazel-contrib#2039 (comment) for more info.
gregmagolan
pushed a commit
to gregmagolan/rules_nodejs
that referenced
this pull request
Jul 16, 2020
…ext.0 LinkablePackageInfo now part of ng_module with that release so patch can be simplified to just patching the @npm_bazel_typescript imports. That minimal path is required for @angular/bazel until the package is upgraded to new rules_nodejs 2.0 package format. See bazel-contrib#2039 (comment) for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for rules_nodejs 2.0 compatability with the current @angular/bazel package, which imports from @npm_bazel_typescript, without having to patch the nnpm package. LinkablePackageInfo was added in @angular/bazel 10.1.0-next.0 release. Together with this fix this allows us to remove the @angular/bazel patches from examples/angular_view_engine entirely.
Future release of @angular/bazel will be updated to the new package format and support @npm//@angular/bazel:index.bzl loads. This is in progress in angular/angular#37727.
@npm_bazel_typescript support will likely be removed in rules_nodejs 3.0.