-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: angular example ts_scripts path in Windows #1605
Conversation
CI failure seems to be unrelated
|
Yes. CI failure was due to inflight conflict with two PRs. Fix is here: #1607. Not related to this. |
Thanks @alan-agius4 . We need some Windows coverage on this example. The /integration/angular is also not tested on Windows on angular repo AFAIK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also make the same change in /examples/angular_view_engine?
Also rebase to master and it should be green now.
In Windows `_/ts_scripts.js` will be expanded to `C:/Program Files/Git/ts_scripts.js`. ``` [ 'C:\\users\\alag\\_bazel_alag\\rj2iva3m\\external\\build_bazel_rules_nodejs\\internal\\node\\_node_bin\\node', 'C:\\users\\alag\\_bazel_alag\\rj2iva3m\\execroot\\examples_angular\\node_modules\\html-insert-assets\\src\\main.js', '--html=src/example/index.html', '--out=bazel-out/x64_windows-fastbuild/bin/src/index.html', '--roots=.', 'bazel-out/x64_windows-fastbuild/bin/src', '--assets', 'bazel-out/x64_windows-fastbuild/bin/src/styles.css', 'external/npm/node_modules/@angular/material/prebuilt-themes/deeppurple-amber.css', 'external/npm/node_modules/zone.js/dist/zone.min.js', './_C:/Program Files/Git/ts_scripts.js' ] ``` This seems like some character escaping issue but in general escaping is hell and this is a more straightforward fix. Partially addresses: #1604
245ea29
to
e01a6ba
Compare
@gregmagolan done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
In Windows
_/ts_scripts.js
will be expanded toC:/Program Files/Git/ts_scripts.js
.This seems like some character escaping issue but in general escaping is hell and this is a more straightforward fix.
Partially addresses: #1604