Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rules_webtesting 0.3.3 #1143

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ npm_package(
srcs = glob(["*.bzl"]) + [
"BUILD.bazel",
"LICENSE",
"rules_webtesting.patch",
],
# Don't rename BUILD files as this package is not published to npm
# but is compressed in "release" below and published as a .tar.gz to GitHub
Expand Down
16 changes: 3 additions & 13 deletions packages/karma/src/package.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,12 @@ def rules_karma_dependencies():
from their WORKSPACE before calling this function, or not call this function at all.
"""

# TypeScript compiler runs on node.js runtime
_maybe(
http_archive,
name = "build_bazel_rules_nodejs",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.18.5/rules_nodejs-0.18.5.tar.gz"],
sha256 = "c8cd6a77433f7d3bb1f4ac87f15822aa102989f8e9eb1907ca0cad718573985b",
)

# ts_web_test depends on the web testing rules to provision browsers.
# karma rules depend on the web testing rules to provision browsers.
_maybe(
http_archive,
name = "io_bazel_rules_webtesting",
sha256 = "f1f4d2c2f88d2beac64c82499a1e762b037966675dd892da89c87e39d72b33f6",
urls = ["https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.2/rules_webtesting.tar.gz"],
patches = ["@build_bazel_rules_nodejs//:rules_webtesting.patch"],
patch_args = ["-p1"],
sha256 = "9bb461d5ef08e850025480bab185fd269242d4e533bca75bfb748001ceb343c3",
urls = ["https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz"],
)

def _maybe(repo_rule, name, **kwargs):
Expand Down
8 changes: 3 additions & 5 deletions packages/protractor/src/package.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,12 @@ def npm_bazel_protractor_dependencies():
from their WORKSPACE before calling this function, or not call this function at all.
"""

# ts_web_test depends on the web testing rules to provision browsers.
# protractor rules depend on the web testing rules to provision browsers.
_maybe(
http_archive,
name = "io_bazel_rules_webtesting",
sha256 = "f1f4d2c2f88d2beac64c82499a1e762b037966675dd892da89c87e39d72b33f6",
urls = ["https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.2/rules_webtesting.tar.gz"],
patches = ["@build_bazel_rules_nodejs//:rules_webtesting.patch"],
patch_args = ["-p1"],
sha256 = "9bb461d5ef08e850025480bab185fd269242d4e533bca75bfb748001ceb343c3",
urls = ["https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz"],
)

def _maybe(repo_rule, name, **kwargs):
Expand Down
171 changes: 0 additions & 171 deletions rules_webtesting.patch

This file was deleted.