Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: parallelize terser runs #1123

Merged
merged 13 commits into from
Sep 19, 2019
Merged

chore: parallelize terser runs #1123

merged 13 commits into from
Sep 19, 2019

Conversation

soldair
Copy link
Collaborator

@soldair soldair commented Sep 12, 2019

this is missing needed negative tests to make sure error output is useful and exit code is correct.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Toxicable
Copy link

If you want I can give you my thoughts on running under worker_threads to do it at the same time? I don't think ill be able to go onto that for about 3 weeks due to Angular Connect then some time off afterwards.

@soldair
Copy link
Collaborator Author

soldair commented Sep 12, 2019

@Toxicable this is meant to be throw away for yours. it should be good enough for a not going to blow up people MVP but i didn't try to make myself happy with it. =)

that said i'm happy to have feedback anywhere just @ me

@alexeagle
Copy link
Collaborator

We should land this now so we can publish the first version of terser_minified and get feedback without eating all the RAMz on someones machine.
We can leave the terser parallel issue open to track the worker_threads which I think would make it faster and consume less resources

packages/terser/src/index.js Outdated Show resolved Hide resolved
packages/terser/src/index.js Outdated Show resolved Hide resolved
packages/terser/src/index.js Outdated Show resolved Hide resolved
packages/terser/src/index.js Show resolved Hide resolved
packages/terser/src/index.js Outdated Show resolved Hide resolved
packages/terser/src/index.js Outdated Show resolved Hide resolved
packages/terser/src/index.js Outdated Show resolved Hide resolved
packages/terser/src/index.js Outdated Show resolved Hide resolved
packages/terser/src/index.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay it's green!

packages/terser/src/index.js Outdated Show resolved Hide resolved
packages/terser/src/index.js Outdated Show resolved Hide resolved
packages/terser/src/index.js Outdated Show resolved Hide resolved
@soldair soldair merged commit e4427b3 into master Sep 19, 2019
@alexeagle alexeagle deleted the parallelize_terser branch September 19, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants