Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@bazel/create --typescript is still on TS 3.4 #1602

Closed
alexeagle opened this issue Feb 4, 2020 · 0 comments · Fixed by #1654
Closed

@bazel/create --typescript is still on TS 3.4 #1602

alexeagle opened this issue Feb 4, 2020 · 0 comments · Fixed by #1654

Comments

@alexeagle
Copy link
Collaborator

It should probably be latest or we should have some scheme for updating it periodically.

See packages/create/index.js
alexeagle added a commit that referenced this issue Feb 13, 2020
@alexeagle
fix(create): install latest typescript
c1cb408 
Note, this could possibly get us in trouble if a runtime failure between new TS version and what tsc_wrapped depends on.

Fixes #1602
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Feb 19, 2020
@alexeagle
fix(create): use latest typescript
15d1722 
Technically this could get us in trouble, if a new TS release isn't compatible with tsc_wrapped.
However we work pretty quickly to resolve these.

Fixes bazel-contrib#1602

The alternative is we could populate this version from whatever TS we test against in this repo so we know it will work
@alexeagle alexeagle mentioned this issue Feb 19, 2020
Merged
alexeagle added a commit that referenced this issue Feb 25, 2020
@alexeagle
fix(create): use latest typescript
a8ba18e 
Technically this could get us in trouble, if a new TS release isn't compatible with tsc_wrapped.
However we work pretty quickly to resolve these.

Fixes #1602

The alternative is we could populate this version from whatever TS we test against in this repo so we know it will work
This was referenced May 23, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(create): use latest typescript alexeagle/rules_nodejs
1 participant
@alexeagle