Skip to content

Commit

Permalink
chore: bump to node 18 LTS as default
Browse files Browse the repository at this point in the history
  • Loading branch information
alexeagle committed Apr 11, 2023
1 parent f0b2046 commit 079f852
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions nodejs/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
# created by the module extension
DEFAULT_NODE_REPOSITORY = "nodejs"

# Currently v16 is the default.
# Currently v18 is the "active" LTS release:
# https://nodejs.dev/en/about/releases/
# We can only change that in a major release of rules_nodejs,
# as it's a semver-breaking change for our users who rely on it.
# We use the most recent v16 release.
DEFAULT_NODE_VERSION = [
# 16.18.1-windows_amd64 -> 16.18.1
v.split("-")[0]
for v in NODE_VERSIONS.keys()
if v.startswith("16.")
if v.startswith("18.")
][-1] # Versions are sorted increasing, so last one is the latest version

BUILT_IN_NODE_PLATFORMS = PLATFORMS.keys()
Expand Down

0 comments on commit 079f852

Please sign in to comment.