Work around Bazel@HEAD bug breaking hermeticity_test
#3729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @linzhp @tyler-french |
fmeum
force-pushed
the
fix-hermeticity-test
branch
from
71d72aa to
2d04256
Compare
|
I have no idea why, but the test is failing with toolchain issues on Windows only when I unflip Bzlmod, which used to be disabled. Very weird. |
|
I will close this PR as I found a fix for the upstream issue: bazelbuild/bazel#19842. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel configdoesn't work correctly with Bzlmod, which is enabled by default with Bazel@HEAD.Fixes #3597
See bazelbuild/bazel#19823