Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap tool paths that contain whitespaces in quotes #732

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

jheaff1
Copy link
Collaborator

@jheaff1 jheaff1 commented Jul 20, 2021

This change is required when using the MSVC toolchain on Windows,
as paths for tools such as the compiler contain whitespaces (e.g.
C:\Program Files...)

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for submitting this!

@UebelAndre UebelAndre enabled auto-merge (squash) July 20, 2021 16:27
auto-merge was automatically disabled July 20, 2021 16:33

Head branch was pushed to by a user without write access

@jheaff1 jheaff1 force-pushed the wrap_paths_with_whitespaces branch from ba294e6 to ae6c151 Compare July 20, 2021 16:33
jheaff1 and others added 2 commits July 20, 2021 17:36
This change is required when using the MSVC toolchain on Windows,
as paths for tools such as the compiler contain whitespaces (e.g.
C:\Program Files\...)
@UebelAndre UebelAndre enabled auto-merge (squash) July 20, 2021 16:42
@UebelAndre UebelAndre merged commit c7330fa into bazel-contrib:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants