Fix quoting of toolchain flags passed to cmake #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsharpe
force-pushed
the
crosstool_quoting
branch
from
18e2bc7 to
e628d5f
Compare
jsharpe
force-pushed
the
crosstool_quoting
branch
9 times, most recently
from
74fbae7 to
569f15d
Compare
jsharpe
force-pushed
the
crosstool_quoting
branch
2 times, most recently
from
aa5dd16 to
8c6bdd2
Compare
jsharpe
force-pushed
the
crosstool_quoting
branch
4 times, most recently
from
379f7f2 to
520dff0
Compare
jsharpe
force-pushed
the
crosstool_quoting
branch
from
520dff0 to
e82ddf9
Compare
UebelAndre
requested changes
Jul 20, 2021
Merged
jsharpe
force-pushed
the
crosstool_quoting
branch
from
d0557ec to
1308557
Compare
jsharpe
force-pushed
the
crosstool_quoting
branch
from
1308557 to
d92fb2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the cmake rule was incorrectly attempting to quote the toolchain flags as they are passed into a HEREDOC in the generated bash script.
This updates the generated bash script to use local variables to pass the flags through to the CMake crosstool file generated by the HEREDOC to avoid having to escape certain characters in those strings. This approach was chosen over disabling expansion in the HEREDOC because it is still desirable to expand some environment variables within the HEREDOC to e.g. access paths for dependencies.