Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coal_mining notebook #21

Merged
merged 13 commits into from
Mar 23, 2021
Merged

add coal_mining notebook #21

merged 13 commits into from
Mar 23, 2021

Conversation

vindex10
Copy link
Collaborator

@vindex10 vindex10 commented Mar 9, 2021

work in progress.

TODO:

  • add more text / descriptions
  • separate data into file, read from it
  • convert to literate jl.

@vindex10 vindex10 added the WIP label Mar 9, 2021
@oschulz oschulz changed the title add coal_mining notebook [WIP] add coal_mining notebook Mar 9, 2021
@codecov-io
Copy link

codecov-io commented Mar 10, 2021

Codecov Report

Merging #21 (cf2a5bd) into master (9ac0497) will increase coverage by 3.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   75.56%   78.71%   +3.14%     
==========================================
  Files           7        7              
  Lines         176      202      +26     
==========================================
+ Hits          133      159      +26     
  Misses         43       43              
Impacted Files Coverage Δ
src/mgvi_impl.jl 100.00% <100.00%> (ø)
src/information.jl 100.00% <0.00%> (ø)
src/jacobian_maps.jl 100.00% <0.00%> (ø)
src/residual_samplers.jl 89.28% <0.00%> (+1.78%) ⬆️
src/shapes.jl 28.57% <0.00%> (+2.64%) ⬆️
src/custom_linear_maps.jl 50.00% <0.00%> (+4.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac0497...cf2a5bd. Read the comment docs.

@oschulz
Copy link
Member

oschulz commented Mar 16, 2021

Very nice now, with Literate. Should I merge this already, or are you still tweaking things a bit?

@oschulz
Copy link
Member

oschulz commented Mar 16, 2021

We should remove the jupyter notebook though, now that the Literate version is in. And maybe rename "intervals.tsv" to "coal_mining_dataset.tsv" or similar?

@vindex10
Copy link
Collaborator Author

vindex10 commented Mar 16, 2021 via email

@vindex10 vindex10 closed this Mar 17, 2021
@vindex10 vindex10 reopened this Mar 17, 2021
@oschulz
Copy link
Member

oschulz commented Mar 17, 2021

Great, thanks!

@oschulz oschulz changed the title [WIP] add coal_mining notebook add coal_mining notebook Mar 23, 2021
@oschulz oschulz merged commit 49dbb1c into master Mar 23, 2021
@oschulz
Copy link
Member

oschulz commented Mar 23, 2021

Thanks!

@oschulz oschulz deleted the feature/coal_mining_example branch March 23, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants