-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add coal_mining notebook #21
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 75.56% 78.71% +3.14%
==========================================
Files 7 7
Lines 176 202 +26
==========================================
+ Hits 133 159 +26
Misses 43 43
Continue to review full report at Codecov.
|
Very nice now, with Literate. Should I merge this already, or are you still tweaking things a bit? |
We should remove the jupyter notebook though, now that the Literate version is in. And maybe rename "intervals.tsv" to "coal_mining_dataset.tsv" or similar? |
it is not yet ready. i will remove the notebook and i had in mind renaming
the file. I'll do that! still have to write descriptions and make sure docs
are building. it is as mess with paths. it built for me locally but
remotely it says file not found
…On Tue, Mar 16, 2021, 22:54 Oliver Schulz ***@***.***> wrote:
We should remove the jupyter notebook though, now that the Literate
version is in. And maybe rename "intervals.tsv" to
"coal_mining_dataset.tsv" or similar?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO7FHCULY364GC4CSHCNXDTD7APXANCNFSM4Y4HLVIQ>
.
|
Great, thanks! |
Thanks! |
work in progress.
TODO: