Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Benchmark Analysis #11

Merged
merged 5 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
/target
/benchmark/*.tsv

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ license = "MIT OR Apache-2.0"
version = "0.3.2"
edition = "2021"
rust-version = "1.70.0"
exclude = [".github", ".gitignore", "*.sh", "*.tsv"]
exclude = [".github", ".gitignore", "*.sh", "benchmark/**/*"]

[dependencies]
thiserror = "1.0.56"
Expand Down
20 changes: 0 additions & 20 deletions benchmark.tsv

This file was deleted.

146 changes: 146 additions & 0 deletions benchmark/measurements.Rmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
---
title: "Measurements"
author: "Jan Hohenheim"
date: "`r Sys.Date()`"
header-includes:
- \usepackage{fontspec}
output:
pdf_document:
latex_engine: xelatex
---

```{r setup, include=FALSE}
knitr::opts_chunk$set(echo = TRUE)
```

## R Markdown

```{r}
library(tidyverse);
library(ggthemes);
library(svglite)
theme_set(theme_solarized_2(light = TRUE));
```

```{r}
dat_raw <- read_tsv("raw.tsv");
dat_raw$term <- as.factor(dat_raw$term);
dat_raw$machine <- as.factor(dat_raw$machine)
dat_raw$supported <- as.logical(dat_raw$supported);
```

```{r}
message("Raw data");
dat_raw |> summary(maxsum = max(lengths(lapply(dat_raw, unique))))

dat_raw |>
group_by(term) |>
summarise(
"mean [ns]" = mean(duration_ns),
"median [ns]" = median(duration_ns),
"sd [ns]" = sd(duration_ns),
);
```

```{r}
message("Filtered data");
alpha <- 0.05;
dat <- dat_raw |>
filter(duration_ns > quantile(duration_ns, alpha / 2) & duration_ns < quantile(duration_ns, 1 - alpha / 2)) |>
mutate(duration_us = duration_ns / 1000) |>
select(-duration_ns);

dat$machine <- dat$machine |>
recode(
"linux" = "Linux Desktop",
"macbook" = "MacBook Pro"
);


dat |> summary(maxsum = max(lengths(lapply(dat, unique))));

dat |>
group_by(term) |>
summarise(
"mean [μs]" = mean(duration_us),
"median [μs]" = median(duration_us),
"sd [μs]" = sd(duration_us),
);

```

## Violin plots


```{r}
for (current_term in unique(dat$term)) {
machine <- dat |>
filter(term == current_term) |>
pull(machine) |>
unique();
plt <- dat |>
filter(term == current_term) |>
ggplot(aes(x = term, y = duration_us)) +
geom_violin() +
ggtitle(glue::glue("Violin plot for {current_term} on {machine}")) +
ylab("Duration [μs]");
print(plt);
}
```


## Histograms

```{r}
for (current_term in unique(dat$term)) {
machine <- dat |>
filter(term == current_term) |>
pull(machine) |>
unique();
plt <- dat |>
filter(term == current_term) |>
ggplot(aes(x = duration_us)) +
geom_histogram(bins = 200) +
ggtitle(glue::glue("Histogram for {current_term} on {machine}")) +
xlab("Duration [μs]");
print(plt);
}
```

## Median plot

```{r}
dat.median <- dat |>
group_by(term, machine) |>
summarise(
median = median(duration_us),
supported = ifelse(first(supported), "True", "False"),
fast = median(duration_us) < 2000,
.groups = "keep",
);

dat.median |>
filter(fast) |>
ggplot(aes(x = term, y = median, fill = supported)) +
geom_bar(stat = "identity", position = "dodge") +
ggtitle("Median duration per terminal for fast terminals") +
ylab("Median duration [μs]") +
xlab("Term") +
scale_fill_manual(values = c(True = "steelblue", False = "coral2")) +
theme(axis.text.x = element_text(angle = 45, hjust = 1));

ggsave("measurements_fast.svg", width = 10, height = 8)

dat.median |>
filter(!fast) |>
ggplot(aes(x = term, y = median, fill = supported)) +
geom_bar(stat = "identity", position = "dodge") +
ggtitle("Median duration per terminal for slow terminals") +
ylab("Median duration [μs]") +
xlab("Term") +
scale_fill_manual(values = c(True = "steelblue", False = "coral2")) +
theme(axis.text.x = element_text(angle = 45, hjust = 1));

ggsave("measurements_slow.svg", width = 10, height = 8)
```

Binary file added benchmark/measurements.pdf
Binary file not shown.
1 change: 1 addition & 0 deletions benchmark/measurements_fast_dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions benchmark/measurements_fast_light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading