-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] change download functions to consume CKAN endpoint #1063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascr91
changed the title
Pr 1016
[infra] modify list_datasets function to consume CKAN endpoint
Jan 15, 2022
lucascr91
changed the title
[infra] modify list_datasets function to consume CKAN endpoint
[infra] modify download functions to consume CKAN endpoint
Jan 15, 2022
lucascr91
changed the title
[infra] modify download functions to consume CKAN endpoint
[infra] modify list_datasets function to consume CKAN endpoint
Jan 15, 2022
lucascr91
changed the title
[infra] modify list_datasets function to consume CKAN endpoint
[infra] modify download functions to consume CKAN endpoint
Jan 15, 2022
lucascr91
changed the title
[infra] modify download functions to consume CKAN endpoint
[infra] change download functions to consume CKAN endpoint
Jan 15, 2022
6 tasks
Esse PR foi transferido para #1129 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1129
Segue uma breve descrição das alterações feitas em cada uma das funções. Procurei manter funcionalidades e parâmetros da função original, quando possível.
search:
Ver: #1016
list_datasets e list_dataset_tables
Assim como as funções originais, as novas funções têm os parâmetros
with_description
everbose
, como os mesmos defaults. O retorno das funções também guarda semelhança com o retorno das funções originais. Por default, as funções retornam um output padronizada pela função_print_output
. Alternativamente, as funções podem retornar o resultado em uma lista, usandoverbose=False
.get_dataset_description, get_table_description, get_table_columns
Mantive as funcionalidades originais e poucas alterações foram feitas nos testes.
Tests
Para facilitar os testes das funções alteradas nesse PR, escrevi um bash: