Add talent protocol discount validator #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cb-elileers
reviewed
Oct 14, 2024
| /// | ||
| /// @return `true` if the validation data provided is determined to be valid for the specified claimer, else `false`. | ||
| function isValidDiscountRegistration(address claimer, bytes calldata) external view returns (bool) { | ||
| return (talentProtocol.getScoreByAddress(claimer) >= threshold); |
There was a problem hiding this comment.
We are fully relying on the TalentProtocol team (a non-coinbase product) to only put valid scores in. We should assume that this can be abused, and limit the discount amounts.
There was a problem hiding this comment.
Duly noted. We have control over whether this discount is active or not on our RegistrarController so I think that's sufficient control. Additionally, we can always update the discount amount associated with this integration.
cb-elileers
reviewed
Oct 14, 2024
cb-elileers
reviewed
Oct 14, 2024
cb-elileers
approved these changes
Oct 15, 2024
abdulla-cb
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding a discount validator for users with minted Builder Scores over some set threshold. This PR implements the discount validator associated with this integration.