Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #117

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions script/deploy/DeployL1Resolver.s.sol
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ import "src/L1/L1Resolver.sol";
contract DeployL1Resolver is Script {
function run() external {
uint256 deployerPrivateKey = vm.envUint("PRIVATE_KEY");
address deployerAddresss = vm.addr(deployerPrivateKey);
address deployerAddress = vm.addr(deployerPrivateKey);
vm.startBroadcast(deployerPrivateKey);

/// L1 Resolver constructor data
string memory url =
"https://api-entry-gateway-development.cbhq.net/api/v1/subdomain/resolver/resolveDomain/{sender}/{data}"; //
address[] memory signers = new address[](1);
signers[0] = 0xa412c16ECd2198A6aBce8235651E105684Fb77ed; // DEV signer
address owner = deployerAddresss;
address owner = deployerAddress;
address rootResolver = 0x8FADE66B79cC9f707aB26799354482EB93a5B7dD; //basetest.eth root resolver on sepolia

L1Resolver l1 = new L1Resolver(url, signers, owner, rootResolver);
Expand Down
2 changes: 1 addition & 1 deletion src/L1/L1Resolver.sol
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ contract L1Resolver is IExtendedResolver, ERC165, Ownable {
/// @param response The response bytes that the client received from the gateway.
/// @param extraData The additional bytes of information from the `OffchainLookup` `extraData` arg.
///
/// @return The bytes of the reponse from the CCIP read.
/// @return The bytes of the response from the CCIP read.
function resolveWithProof(bytes calldata response, bytes calldata extraData) external view returns (bytes memory) {
(address signer, bytes memory result) = SignatureVerifier.verify(extraData, response);
if (!signers[signer]) revert InvalidSigner();
Expand Down
2 changes: 1 addition & 1 deletion test/EARegistrarController/DiscountedRegister.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ contract DiscountedRegister is EARegistrarControllerBase {
controller.discountedRegister{value: price}(_getDefaultRegisterRequest(), discountKey, "");
}

function test_reverts_whenNameNotAvailble() public {
function test_reverts_whenNameNotAvailable() public {
vm.deal(user, 1 ether);
vm.prank(owner);
controller.setDiscountDetails(_getDefaultDiscount());
Expand Down
2 changes: 1 addition & 1 deletion test/RegistrarController/DiscountedRegister.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ contract DiscountedRegister is RegistrarControllerBase {
controller.discountedRegister{value: price}(_getDefaultRegisterRequest(), discountKey, "");
}

function test_reverts_whenNameNotAvailble() public {
function test_reverts_whenNameNotAvailable() public {
vm.deal(user, 1 ether);
vm.prank(owner);
controller.setDiscountDetails(_getDefaultDiscount());
Expand Down
2 changes: 1 addition & 1 deletion test/RegistrarController/Register.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ contract Register is RegistrarControllerBase {
controller.register{value: price}(noResolverRequest);
}

function test_reverts_whenNameNotAvailble() public {
function test_reverts_whenNameNotAvailable() public {
vm.deal(user, 1 ether);
uint256 price = controller.registerPrice(name, duration);
base.setAvailable(uint256(nameLabel), false);
Expand Down