Reduce storge depth from 10 to 2 to reduce condition number and make …

…portable (trilinos#2247)

This change reduces the condition number of the least-squares problem from
10^12 to 10^4 and results in more stable floating point computations and
better portability of the test.

This fixes the failures with the Intel compiler 17.0.1 with optimized compiler
flags (see trilinos#2247).

Also has to change number of expected iterations from 18 to 11.

I tested this with Intel and GNU builds and they both passed:

Enabled Packages: NOX
Enabled all Forward Packages

1) intel-opt-openmp => passed: passed=105,notpassed=0 (2.65 min)
2) gnu-opt-openmp => passed: passed=105,notpassed=0 (8.81 min)

Change expected iters from 18 to 11 (trilinos#2247)

packages/nox/test/epetra/Thyra/Thyra_Heq.C

@@ -98,7 +98,7 @@ int main(int argc, char *argv[])
 
   bool success = false;
   bool verbose = false;
-  int StorageDepth = 10;
+  int StorageDepth = 2;
   double ParamC = 0.999;
   std::string LineSearch = "Full Step";
   int Reorthogonalize = 0;
@@ -250,7 +250,7 @@ int main(int argc, char *argv[])
     {
       numIterations = *numItersPtr;
     } 
-    TEUCHOS_TEST_EQUALITY_CONST(numIterations, 18, *out, loc_success);
+    TEUCHOS_TEST_EQUALITY_CONST(numIterations, 11, *out, loc_success);
     // 3. Same reset solution
     TEUCHOS_TEST_COMPARE_CONST(diff->norm(), <=, 1.0e-14, *out, loc_success);