Skip to content

Commit

Permalink
Address review comments from @bartlettroscoe from TriBITSPub#481
Browse files Browse the repository at this point in the history
  • Loading branch information
bartlettroscoe committed Jul 18, 2022
1 parent 35ddbe8 commit 0ac69f4
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions tribits/core/package_arch/TribitsAddAdvancedTest.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -521,8 +521,8 @@ include(PrintVar)
# **any** of the given regular expressions. This will be applied and take
# precedence over other above pass criteria. For example, if even if
# ``PASS_REGULAR_EXPRESSION`` or ``PASS_REGULAR_EXPRESSION_ALL`` match,
# then the test will be marked as failed if this fail regex matches the
# output.
# then the test will be marked as failed if any of the fail regexes match
# the output.
#
# ``ALWAYS_FAIL_ON_NONZERO_RETURN``
#
Expand Down Expand Up @@ -605,7 +605,7 @@ include(PrintVar)
# The logic given below can be used to determine pass/fail criteria for a test
# case both based on what is printed in the test output **and** the return
# code for the test block command. Raw CTest, as of version 3.23, does not
# allow that. With raw CTest, one can only set determine pass/fail based the
# allow that. With raw CTest, one can only set pass/fail criteria based the
# test output **or** the return code, but not both. This make
# `tribits_add_advanced_test()`_ more attractive to use than
# `tribits_add_test()`_ or raw ``add_test()`` in cases where it is important
Expand Down Expand Up @@ -682,9 +682,8 @@ include(PrintVar)
# ``FINAL_PASS_REGULAR_EXPRESSION "<regex0>" "<regex1>" ...``
#
# If specified, the test will be assumed to pass if the output matches
# **any** of the provided regular expressions ``<regexi>``. Otherwise, it
# will be assumed to fail. (Sets the CTest property
# ``PASS_REGULAR_EXPRESSION`` for the overall test.)
# **any** of the provided regular expressions ``<regexi>``. (Sets the
# CTest property ``PASS_REGULAR_EXPRESSION`` for the overall test.)
#
# ``FINAL_FAIL_REGULAR_EXPRESSION "<regex0>" "<regex1>" ...``
#
Expand Down

0 comments on commit 0ac69f4

Please sign in to comment.