Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the system-agnostic
access
argument instead of the posix specificprot
when initializing mmap.Currently when trying to load a binary file, I get this error:
I tested this again using WSL and everything worked fine. In the end this comes down to the fact that the
prot
argument in the MMap init function is POSIX-specific, whileaccess
serves as a system-agnostic way of doing the same thing. I changed the init line and tested this change on both windows and and WSL and this error is gone.Here's the relevant docs for MMap: link
Please merge ASAP as this breaks usage on windows.