feat(logs): Expose logs level to the user #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Implement asserts with plenary testing framework
Restructured the way that logs operate. The `init(level)` function no longer receives a `level`. Instead, the setup reads the settings from package.load. This allows to have the same behavior for all the modules that require to use logs. The `plenary` dependency is handled by a pcall statement. If the user hasn't installed `plenary`, be notified and use the built-in logs. This also applies to the logging level "none".
Intermediate commit, the next one contain the neccesary fixes. Allow debug configuration in setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.