修复分页优化distinct搭配orderBy处理错误.

#6105
baomidou · Apr 26, 2024 · 74b5d38 · 74b5d38
1 parent 745862d
commit 74b5d38
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/...ain/java/com/baomidou/mybatisplus/extension/plugins/inner/PaginationInnerInterceptor.java b/...ain/java/com/baomidou/mybatisplus/extension/plugins/inner/PaginationInnerInterceptor.java
@@ -267,13 +267,6 @@ public String autoCountSql(IPage<?> page, String sql) {
                 return lowLevelCountSql(sql);
             }
             PlainSelect plainSelect = (PlainSelect) select;
-            Distinct distinct = plainSelect.getDistinct();
-            GroupByElement groupBy = plainSelect.getGroupBy();
-
-            // 包含 distinct、groupBy 不优化
-            if (null != distinct || null != groupBy) {
-                return lowLevelCountSql(select.toString());
-            }
 
             // 优化 order by 在非分组情况下
             List<OrderByElement> orderBy = plainSelect.getOrderByElements();
@@ -291,7 +284,12 @@ public String autoCountSql(IPage<?> page, String sql) {
                     plainSelect.setOrderByElements(null);
                 }
             }
-
+            Distinct distinct = plainSelect.getDistinct();
+            GroupByElement groupBy = plainSelect.getGroupBy();
+            // 包含 distinct、groupBy 不优化
+            if (null != distinct || null != groupBy) {
+                return lowLevelCountSql(select.toString());
+            }
             //#95 Github, selectItems contains #{} ${}, which will be translated to ?, and it may be in a function: power(#{myInt},2)
             for (SelectItem item : plainSelect.getSelectItems()) {
                 if (item.toString().contains(StringPool.QUESTION_MARK)) {

diff --git a/...com/baomidou/mybatisplus/test/extension/plugins/inner/PaginationInnerInterceptorTest.java b/...com/baomidou/mybatisplus/test/extension/plugins/inner/PaginationInnerInterceptorTest.java
@@ -31,6 +31,10 @@ void optimizeCount() {
 
         assertsCountSql("select * from user u LEFT JOIN role r ON r.id = u.role_id LEFT JOIN permission p on p.id = u.per_id WHERE u.xx = ?",
             "SELECT COUNT(*) AS total FROM user u WHERE u.xx = ?");
+
+        assertsCountSql("select distinct id from table order by id", "SELECT COUNT(*) FROM (SELECT DISTINCT id FROM table) TOTAL");
+
+        assertsCountSql("select distinct id from table", "SELECT COUNT(*) FROM (SELECT DISTINCT id FROM table) TOTAL");
     }
 
     @Test