Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adding validation for node pool names (only accept lowercase characters and numbers) for clusters created on AWS.
Why?
The
eks-create-asg
Cadence workflow errors if there are special characters because the node pool name gets attached to the stack name; also theconfigure-nodepool-labels
workflow errors if there are uppercase characters in the nood pool name resulting in unsuccessful cluster creation, so it is useful if a validator catches these cases even before the cluster creation begins.Additional context
Example config.yaml:
Response (banzai CLI):
Checklist
[] OpenAPI and Postman files updated (if needed)[] User guide and development docs updated (if needed)[] Related Helm chart(s) updated (if needed)