Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: secret selection done on provider level #203

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat: secret selection done on provider level #203

merged 2 commits into from
Sep 17, 2024

Conversation

csatib02
Copy link
Member

Overview

  • Makes env selection flow through providers.
  • Changes Bao image to latest release.

Fixes #137

@csatib02 csatib02 requested a review from a team as a code owner July 30, 2024 07:53
@csatib02 csatib02 requested review from akijakya, sagikazarmark and ramizpolic and removed request for a team July 30, 2024 07:53
@csatib02 csatib02 self-assigned this Jul 30, 2024
@csatib02 csatib02 added the kind/enhancement Categorizes issue or PR as related to an improvement. label Jul 30, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Jul 30, 2024
@csatib02 csatib02 force-pushed the feat/secret-selection-done-on-provider-level branch from c1507ee to 9b379a3 Compare August 27, 2024 13:22
@csatib02 csatib02 force-pushed the feat/secret-selection-done-on-provider-level branch from 9b379a3 to 0871b46 Compare September 14, 2024 13:08
@csatib02 csatib02 force-pushed the feat/secret-selection-done-on-provider-level branch from 0871b46 to 56df92d Compare September 14, 2024 13:12
@csatib02 csatib02 mentioned this pull request Sep 14, 2024
Merged
@github-actions github-actions bot added size/XL Denotes a PR that changes 1000+ lines and removed size/L Denotes a PR that changes 500-999 lines labels Sep 14, 2024
@csatib02
chore: rebase changes
949dad5 
Signed-off-by: Bence Csati <[email protected]>

chore: rebase changes

Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 force-pushed the feat/secret-selection-done-on-provider-level branch from 3028278 to 949dad5 Compare September 14, 2024 13:34
@csatib02 csatib02 merged commit 34ec985 into main Sep 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@akijakya akijakya Awaiting requested review from akijakya akijakya is a code owner automatically assigned from bank-vaults/maintainers

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

Assignees

@csatib02 csatib02

Labels
kind/enhancement Categorizes issue or PR as related to an improvement. size/XL Denotes a PR that changes 1000+ lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add env selector to provider implementations
2 participants
@csatib02 @ramizpolic