Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

pyband: raw_log can be none and get KeyError exception #3084

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

taobun
Copy link
Member

@taobun taobun commented Jan 18, 2021

Implementation details

Some error didn't return raw_log that make key missing or tx response.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@taobun taobun requested review from evilpeach and pzshine January 18, 2021 12:01
@render
Copy link

render bot commented Jan 18, 2021

Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add unit test for this case.

@taobun taobun requested a review from evilpeach January 19, 2021 13:13
@evilpeach evilpeach merged commit c76d335 into master Jan 22, 2021
@evilpeach evilpeach deleted the raw-log-can-be-none branch January 22, 2021 03:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants