Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Pyband: Added the address to account dataclass #2897

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Nov 17, 2020

Implementation details

  • Added the Address to Account dataclass
  • Fixed the test case
  • Added new __eq__ to Address class on wallet module
  • Moved the msg tests to message folder

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Nov 17, 2020

@evilpeach evilpeach merged commit 1acd12c into master Nov 18, 2020
@evilpeach evilpeach deleted the pyband-address-type branch November 18, 2020 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants