Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented the msg on TxMobileTable for GUANYU #2394

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 5, 2020

Fixed: #2360

Implementation details

  • Implemented the Message on TxMobileTable.
  • Fixed some layout bug.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 5, 2020 10:21
@render
Copy link

render bot commented Aug 5, 2020

scan/src/reusable/InfoMobileCard.re Outdated Show resolved Hide resolved
scan/src/reusable/InfoMobileCard.re Outdated Show resolved Hide resolved
scan/src/reusable/InfoMobileCard.re Outdated Show resolved Hide resolved
@pzshine pzshine requested a review from evilpeach August 7, 2020 11:50
@pzshine pzshine force-pushed the mobile-msg-for-guanyu branch from fe1603b to 528e2ca Compare August 7, 2020 11:59
@evilpeach evilpeach merged commit 3ca6a77 into master Aug 7, 2020
@evilpeach evilpeach deleted the mobile-msg-for-guanyu branch August 7, 2020 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Guan Yu and Proposal message on mobile
2 participants