Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented the sort function for validator homepage #2334

Merged
merged 6 commits into from
Jul 30, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Jul 29, 2020

Fixed: #2321

Implementation details

  • Implemented the sorting dropdown on the validator homepage's mobile layout.
  • Fixed scroll issue when page redirection.
  • CSS refactoring a bit.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach July 29, 2020 12:21
@render
Copy link

render bot commented Jul 29, 2020

@pzshine pzshine changed the title 💄 Implemented the sort function for validator homepage Scan: Implemented the sort function for validator homepage Jul 29, 2020
@pzshine pzshine force-pushed the mobile-sorting-validator branch from 1106ebf to 3851737 Compare July 29, 2020 12:43
scan/src/pages/ValidatorHomePage.re Outdated Show resolved Hide resolved
scan/src/components/ValidatorsTable.re Outdated Show resolved Hide resolved
scan/src/images/Images.re Outdated Show resolved Hide resolved
scan/src/pages/ValidatorHomePage.re Outdated Show resolved Hide resolved
@pzshine pzshine force-pushed the mobile-sorting-validator branch from 3b435fb to 4dabbb7 Compare July 30, 2020 03:58
scan/src/pages/ValidatorHomePage.re Outdated Show resolved Hide resolved
@pzshine pzshine merged commit ef7fa8f into master Jul 30, 2020
@pzshine pzshine deleted the mobile-sorting-validator branch July 30, 2020 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting selection on Validator Home Page (mobile)
2 participants