Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Fix bug accumulated_commission in emitSetValidator #2298

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Jul 23, 2020

Implementation details

accumulated_commission MUST be string

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

If this PR doesn't need to be merged into v1.0.6 please remove this option:

  • The pull request has been cherry-picked to rc/1.0.6

@Benzbeeb Benzbeeb requested review from sorawit and taobun July 23, 2020 08:47
@render
Copy link

render bot commented Jul 23, 2020

@taobun taobun merged commit fc4c01b into master Jul 23, 2020
@taobun taobun deleted the fix-set-val-bug branch July 23, 2020 09:33
taobun added a commit that referenced this pull request Jul 23, 2020
Fix bug `accumulated_commission` in `emitSetValidator`
taobun added a commit that referenced this pull request Jul 23, 2020
Fix bug `accumulated_commission` in `emitSetValidator`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants