Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Change gas consumption amount when call set return data. #2292

Merged
merged 3 commits into from
Jul 22, 2020

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Jul 22, 2020

Implementation details

  1. Change gas consume = spansize
  2. Check env.RetData == nil before set return data
  3. Implement test

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

If this PR doesn't need to be merged into v1.0.6 please remove this option:

  • The pull request has been cherry-picked to rc/1.0.6

@Benzbeeb Benzbeeb requested review from sorawit and taobun July 22, 2020 08:30
@render
Copy link

render bot commented Jul 22, 2020

go-owasm/src/error.rs Outdated Show resolved Hide resolved
go-owasm/src/lib.rs Show resolved Hide resolved
@Benzbeeb Benzbeeb requested a review from sorawit July 22, 2020 09:12
Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@taobun taobun merged commit 554ddaa into master Jul 22, 2020
@taobun taobun deleted the fix-read-gas-consume branch July 22, 2020 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants