Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

hotfix: handle_set_validator get wrong validator id #2252

Merged
merged 2 commits into from
Jul 19, 2020

Conversation

taobun
Copy link
Member

@taobun taobun commented Jul 18, 2020

Implementation details

  • This makes set_validator try to create a new row because cannot find existed validator id. And fail on integrity constraint check.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request includes a description of the implementation/work done in detail.
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@taobun taobun requested review from sorawit and Benzbeeb July 18, 2020 07:01
@render
Copy link

render bot commented Jul 18, 2020

@taobun taobun changed the title hotfix: Set validator get wrong validator id hotfix: handle_set_validator get wrong validator id Jul 18, 2020
Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taobun taobun merged commit 2dcb49b into master Jul 19, 2020
@taobun taobun deleted the fix-set-validator-bug branch July 19, 2020 06:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants