Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

yoda/docker: Run test program during initialization #2249

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

sorawit
Copy link
Member

@sorawit sorawit commented Jul 17, 2020

Implementation details

Add a test run during Docker exec initialization to make sure it's runnable. Better fail fast!

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@sorawit sorawit requested review from Benzbeeb and taobun July 17, 2020 07:06
@render
Copy link

render bot commented Jul 17, 2020

@sorawit sorawit merged commit 903c7c0 into master Jul 17, 2020
@sorawit sorawit deleted the yoda-docker-test-first branch July 17, 2020 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants