Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

lambda: Support non-standard python package #2210

Merged
merged 10 commits into from
Jul 13, 2020
Merged

lambda: Support non-standard python package #2210

merged 10 commits into from
Jul 13, 2020

Conversation

taobun
Copy link
Member

@taobun taobun commented Jul 12, 2020 •
edited
Loading

Implementation details

  • Implement a script to zip all packages to a zip file

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@taobun taobun requested a review from sorawit July 12, 2020 12:18
@render
Copy link

render bot commented Jul 12, 2020

Your Render PR Server URL is https://d3n-scan-pr-2210.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-bs5fvagl1r152nsvn6eg.

sorawit
sorawit suggested changes Jul 12, 2020
View reviewed changes
runtime/lambda/.gitignore Outdated Show resolved Hide resolved
runtime/lambda/pack.sh Show resolved Hide resolved
@taobun taobun requested a review from sorawit July 12, 2020 12:31
sorawit
sorawit suggested changes Jul 13, 2020
View reviewed changes
runtime/lambda/README.md Outdated Show resolved Hide resolved
runtime/lambda/requirements.txt Outdated Show resolved Hide resolved
runtime/Makefile Outdated Show resolved Hide resolved
@taobun taobun requested a review from sorawit July 13, 2020 09:34
sorawit
sorawit approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sorawit sorawit merged commit 67848bf into master Jul 13, 2020
@sorawit sorawit deleted the lambda-external-module branch July 13, 2020 11:24
@taobun taobun mentioned this pull request Jul 21, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 9, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sorawit sorawit sorawit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taobun @sorawit