Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

chain/yoda: Add commands for improve experience of starting yoda process #2204

Merged
merged 5 commits into from
Jul 13, 2020

Conversation

taobun
Copy link
Member

@taobun taobun commented Jul 11, 2020

Implementation details

  • Add multi-send command in the same level of send cmd to send coin from 1 account to multiple accounts with the same amount.
  • Add add-reporters command to pack MsgAddReports in one transaction.
  • Add flag in yoda keys list to get only address using in multi-send and add-reporters command. Look example at start_yoda.sh.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests. (Test by run chain can request and report correctly)
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@taobun taobun requested a review from sorawit July 11, 2020 12:57
@render
Copy link

render bot commented Jul 11, 2020

@taobun taobun changed the title chain/yoda: Add commands for improve experience chain/yoda: Add commands for improve experience of starting yoda process Jul 11, 2020
Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some comments from me.

chain/x/oracle/client/cli/tx.go Show resolved Hide resolved
chain/x/oracle/client/cli/tx.go Outdated Show resolved Hide resolved
chain/x/oracle/client/cli/tx.go Outdated Show resolved Hide resolved
chain/cmd/bandcli/multi_send.go Outdated Show resolved Hide resolved
chain/cmd/bandcli/multi_send.go Outdated Show resolved Hide resolved
chain/cmd/bandcli/multi_send.go Outdated Show resolved Hide resolved
@taobun taobun requested review from sorawit and Benzbeeb July 12, 2020 05:46
Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@taobun taobun requested a review from tansawit July 13, 2020 04:07
@sorawit sorawit merged commit 64e6853 into master Jul 13, 2020
@sorawit sorawit deleted the bandcli-extra-cmd branch July 13, 2020 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants