Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Flusher: change external id to BigInteger #2182

Merged
merged 5 commits into from
Jul 9, 2020
Merged

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Jul 8, 2020

Implementation details

  1. change external id to BigInteger

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Benzbeeb Benzbeeb requested review from sorawit, evilpeach and taobun July 8, 2020 13:38
@render
Copy link

render bot commented Jul 8, 2020

flusher/flusher/db.py Show resolved Hide resolved
@Benzbeeb Benzbeeb force-pushed the change-ext-id-to-big-int branch from 7710f2a to 0ea591c Compare July 8, 2020 13:47
@Benzbeeb Benzbeeb requested a review from sorawit July 8, 2020 13:48
Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Benzbeeb Benzbeeb merged commit 128aaec into master Jul 9, 2020
@Benzbeeb Benzbeeb deleted the change-ext-id-to-big-int branch July 9, 2020 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants