Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

add field id in accounts table #2178

Merged
merged 8 commits into from
Jul 9, 2020
Merged

add field id in accounts table #2178

merged 8 commits into from
Jul 9, 2020

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Jul 8, 2020

Implementation details

  1. Add field id in accounts table.
  2. Change all foreign key that refers from account address to id.
  3. Fix flusher handler

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Benzbeeb Benzbeeb requested review from sorawit and taobun July 8, 2020 11:03
@render
Copy link

render bot commented Jul 8, 2020

flusher/flusher/handler.py Outdated Show resolved Hide resolved
flusher/flusher/handler.py Outdated Show resolved Hide resolved
flusher/flusher/handler.py Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb requested a review from taobun July 9, 2020 05:53
@Benzbeeb Benzbeeb merged commit cbd63dd into master Jul 9, 2020
@Benzbeeb Benzbeeb deleted the db-add-field-acc-id branch July 9, 2020 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants