Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Add missing FK in report table #2160

Merged
merged 6 commits into from
Jul 7, 2020
Merged

Add missing FK in report table #2160

merged 6 commits into from
Jul 7, 2020

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Jul 6, 2020

Implementation details

  1. Add FK for reports table

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Benzbeeb Benzbeeb requested review from sorawit, evilpeach and taobun July 6, 2020 12:01
@render
Copy link

render bot commented Jul 6, 2020

chain/emitter/oracle.go Outdated Show resolved Hide resolved
chain/emitter/oracle.go Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb changed the title Add missing field in raw reports and reports table Add missing FK in report table Jul 6, 2020
@Benzbeeb Benzbeeb requested a review from sorawit July 6, 2020 13:51
@taobun taobun force-pushed the add-os-id-in-reports branch from d7ab8ba to 118ffcb Compare July 7, 2020 08:34
@Benzbeeb Benzbeeb merged commit 86c5394 into master Jul 7, 2020
@Benzbeeb Benzbeeb deleted the add-os-id-in-reports branch July 7, 2020 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants