Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

chain: Various minor improvements and unit tests #2146

Merged
merged 2 commits into from
Jul 4, 2020

Conversation

sorawit
Copy link
Member

@sorawit sorawit commented Jul 4, 2020

Implementation details

  • Use HasResult to determine if a request has already been resolved.
  • Take reports list in ExecuteEnv creator.
  • Add more unit tests for result keeper.
  • Refactor handler unit tests and make sure test event emits.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@sorawit sorawit requested review from Benzbeeb and taobun July 4, 2020 05:35
@render
Copy link

render bot commented Jul 4, 2020


// SetReports loads the reports to the environment.
func (env *ExecuteEnv) SetReports(reports []Report) {
func NewExecuteEnv(req Request, reports []Report) *ExecuteEnv {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So brilliant!

@sorawit sorawit merged commit 6b1ed36 into master Jul 4, 2020
@sorawit sorawit deleted the more-test-and-impl-cleanup branch July 4, 2020 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants