Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

chain: Update SetResult (Resolve) keeper signature and remove extra events #2137

Merged
merged 11 commits into from
Jul 3, 2020

Conversation

sorawit
Copy link
Member

@sorawit sorawit commented Jul 3, 2020

Implementation details

Make SetResult consistent with GetResult


Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@sorawit sorawit requested review from Benzbeeb and taobun July 3, 2020 12:48
@render
Copy link

render bot commented Jul 3, 2020

@sorawit sorawit force-pushed the set-result-patch branch from 479d4c5 to 15b4689 Compare July 3, 2020 13:20
@sorawit sorawit changed the title chain: Update SetResult keeper signature chain: Update SetResult (Resolve) keeper signature and remove extra events Jul 3, 2020
@sorawit sorawit force-pushed the set-result-patch branch from 30fc5ce to 8435142 Compare July 3, 2020 15:07
@sorawit sorawit merged commit effd9e9 into master Jul 3, 2020
@sorawit sorawit deleted the set-result-patch branch July 3, 2020 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants