Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

chain: Fix request with duplicate external id and empty raw request bug. #2125

Merged
merged 7 commits into from
Jul 2, 2020

Conversation

taobun
Copy link
Member

@taobun taobun commented Jul 2, 2020

Implementation details

  • Add new error when asking external data on duplicate external id.
  • Exec env checks incoming external data request and returns an error if it already has external data request that using same external id.
  • Update build flow of shared library in Linux and mac-os

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@taobun taobun requested review from sorawit, Benzbeeb and perimeko July 2, 2020 05:36
@render
Copy link

render bot commented Jul 2, 2020

@sorawit sorawit changed the title Check duplicate external id chain: Check duplicate external id Jul 2, 2020
@taobun taobun changed the title chain: Check duplicate external id chain: Fix request with duplicate external id and empty raw request bug. Jul 2, 2020
go-owasm/api/error.go Outdated Show resolved Hide resolved
chain/x/oracle/testapp/wasm_3_empty_raw_request.go Outdated Show resolved Hide resolved
@taobun taobun force-pushed the error-ask-duplicate-external-id branch from 401e454 to 99d2dfa Compare July 2, 2020 09:55
@taobun taobun requested a review from sorawit July 2, 2020 09:55
go-owasm/src/error.rs Outdated Show resolved Hide resolved
@taobun taobun requested a review from sorawit July 2, 2020 10:55
@taobun taobun merged commit f264a44 into master Jul 2, 2020
@taobun taobun deleted the error-ask-duplicate-external-id branch July 2, 2020 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants