Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

cdb: Delegation table emitter and flusher #2118

Merged
merged 8 commits into from
Jul 3, 2020
Merged

cdb: Delegation table emitter and flusher #2118

merged 8 commits into from
Jul 3, 2020

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Jul 1, 2020 •
edited
Loading

Fixed: #2086

Implementation details

  1. Add Delegations table
  2. Implement emitDelegation to update message to Kafka
  3. Implement handler in flusher

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Benzbeeb Benzbeeb requested review from sorawit, taobun and perimeko July 1, 2020 14:01
@render
Copy link

render bot commented Jul 1, 2020

Your Render PR Server URL is https://d3n-scan-pr-2118.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-bru9ek8951caka6i3ejg.

tansawit
tansawit previously requested changes Jul 2, 2020
View reviewed changes
chain/emitter/delegation.go Outdated Show resolved Hide resolved
sorawit
sorawit suggested changes Jul 3, 2020
View reviewed changes
flusher/flusher/db.py Outdated Show resolved Hide resolved
flusher/flusher/db.py Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb force-pushed the db-delegation-emitter-flusher branch 3 times, most recently from 18b94d6 to 641f70e Compare July 3, 2020 07:55
@Benzbeeb Benzbeeb requested review from sorawit and tansawit July 3, 2020 07:56
@Benzbeeb Benzbeeb force-pushed the db-delegation-emitter-flusher branch from cd302a6 to 203a67f Compare July 3, 2020 13:31
sorawit
sorawit suggested changes Jul 3, 2020
View reviewed changes
flusher/flusher/handler.py Show resolved Hide resolved
flusher/flusher/db.py Outdated Show resolved Hide resolved
flusher/flusher/db.py Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb requested a review from sorawit July 3, 2020 14:09
@Benzbeeb Benzbeeb merged commit 9e1f156 into master Jul 3, 2020
@Benzbeeb Benzbeeb deleted the db-delegation-emitter-flusher branch July 3, 2020 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sorawit sorawit sorawit approved these changes

@tansawit tansawit tansawit approved these changes

@taobun taobun Awaiting requested review from taobun taobun is a code owner

@perimeko perimeko Awaiting requested review from perimeko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdb: Delegation table emitter and flusher
3 participants
@Benzbeeb @sorawit @tansawit