Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Implement emitter handle MsgEditDataSource/OracleScript. #2115

Merged
merged 5 commits into from
Jul 3, 2020

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Jul 1, 2020

Fixed: #2070

Implementation details

  1. Implement function set data source/oracle script for sending msg to Kafka.
  2. Implement set_data_source/oracle_script handler for flusher.
  3. Implement handle msgEditDataSource/OracleScript.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Benzbeeb Benzbeeb requested review from sorawit, taobun and perimeko July 1, 2020 05:05
@render
Copy link

render bot commented Jul 1, 2020

chain/emitter/oracle.go Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb force-pushed the db-handle-edit-ds-os branch from 3cc3c25 to 47e5f7b Compare July 3, 2020 09:13
@Benzbeeb Benzbeeb requested a review from sorawit July 3, 2020 09:13
chain/emitter/oracle.go Outdated Show resolved Hide resolved
chain/emitter/oracle.go Outdated Show resolved Hide resolved
chain/emitter/handler.go Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb force-pushed the db-handle-edit-ds-os branch from f183e7b to 8a17eed Compare July 3, 2020 16:54
@Benzbeeb Benzbeeb requested a review from taobun July 3, 2020 16:54
@taobun taobun merged commit 99f3f2b into master Jul 3, 2020
@taobun taobun deleted the db-handle-edit-ds-os branch July 3, 2020 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit data source/oracle script on DB
3 participants