This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
chain: Introduce the notion of active validators who are performing oracle tasks #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://d3n-scan-pr-2111.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-brtfc541do6gah3hktm0. |
taobun
suggested changes
Jun 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's abci.go
to perform begin block logic of oracle?
chain/x/oracle/types/key.go
Outdated
@@ -41,6 +41,8 @@ var ( | |||
ReporterStoreKeyPrefix = []byte{0x05} | |||
// ReportInfoKeyPrefix is the prefix for validator report info store. | |||
ReportInfoKeyPrefix = []byte{0x06} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this key
taobun
approved these changes
Jun 30, 2020
Tests will be added in separate commits |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details
The PR adds the concept of "active" validators who are performing oracle tasks on BandChain and replace ReportInfo completely.
With this PR, validators are marked "active" if they are actively performing oracle tasks (report data). If a validator fails to report data, they are immediately switched back to "inactive" and cannot switch back to "active" until after certain duration. Block rewards (inflation + tx fee) are split into two pools, one will be rewarded to all currently active validators, while the other will be rewarded to all bonded validators as usual.
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.md
Files changed
tab in the Github PR explorer)