This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
emitter/flusher: Initial implementation #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://d3n-scan-pr-2022.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-brn3e3qk11rjacrmjpig. |
sorawit
force-pushed
the
emitter-flusher-v0
branch
from
8af621f to
e7f4e4b
Compare
tansawit
suggested changes
Jun 22, 2020
taobun
suggested changes
Jun 23, 2020
| } | ||
| switch msg := msg.(type) { | ||
| case oracle.MsgRequestData: | ||
| app.handleMsgRequestData(txHash, msg, evMap, extra) |
There was a problem hiding this comment.
Why does this function choose to send extra instead of return extra like handleMsg?
There was a problem hiding this comment.
So we don't need to create a new JsDict instance everywhere.
taobun
approved these changes
Jun 24, 2020
Benzbeeb
approved these changes
Jun 25, 2020
sorawit
force-pushed
the
emitter-flusher-v0
branch
from
c7e4cbf to
71f9c78
Compare
tansawit
approved these changes
Jun 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of emitter/flusher.
Emitter is an add-on to BandApp to publish state changes to remote Kafka. Currently messages are flushed on every Commit.
Flusher is a separate Python process that subscribes to messages the push changes to remote databases. It maintains the offset of Kafka messages to make sure no messages are missed.
This is POC implementation. More performance optimizations and features will be added in the future.