Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

scan: show commission max rate and change on validator index page #2005

Merged
merged 10 commits into from
Jun 23, 2020

Conversation

tansawit
Copy link
Contributor

Fixes: #1969

@render
Copy link

render bot commented Jun 18, 2020

@evilpeach evilpeach self-requested a review June 20, 2020 03:49
scan/src/subscriptions/ValidatorSub.re Outdated Show resolved Hide resolved
@tansawit tansawit requested a review from evilpeach June 21, 2020 11:55
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use Format.fPercent(~digits=2) on commission rate, commission max change, commission max rate and uptime.

@evilpeach evilpeach requested a review from prin-r June 22, 2020 08:36
@evilpeach evilpeach merged commit 9f6a33f into master Jun 23, 2020
@evilpeach evilpeach deleted the 1969-show-commission-max-rate-change branch June 23, 2020 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add min_commission_change, max_commission on Validator Index Page
3 participants