Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Implement safe guard to check memory limit from wasm #1988

Merged
merged 14 commits into from
Jun 17, 2020

Conversation

Benzbeeb
Copy link
Contributor

Fixed #1965

@Benzbeeb Benzbeeb requested review from sorawit, taobun and perimeko June 16, 2020 09:49
@render
Copy link

render bot commented Jun 16, 2020

@render
Copy link

render bot commented Jun 16, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@render
Copy link

render bot commented Jun 16, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@render
Copy link

render bot commented Jun 16, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

go-owasm/src/lib.rs Show resolved Hide resolved
@Benzbeeb Benzbeeb requested a review from sorawit June 16, 2020 12:40
@render
Copy link

render bot commented Jun 16, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@Benzbeeb Benzbeeb force-pushed the add-memory-safe-guard branch from 3123864 to 721ea76 Compare June 17, 2020 08:23
@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@Benzbeeb Benzbeeb force-pushed the add-memory-safe-guard branch from 582715b to 501bf77 Compare June 17, 2020 09:02
@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1988.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brk9b6c1do6klrdu7nag.

@Benzbeeb Benzbeeb merged commit fbb8eaf into master Jun 17, 2020
@Benzbeeb Benzbeeb deleted the add-memory-safe-guard branch June 17, 2020 09:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement safe guard to check memory limit from wasm
3 participants